cli: refactor to separate K8s and image upgrade #2331
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for constellation-docs canceled.
|
Coverage report
|
elchead
force-pushed
the
ref/cli/split-k8s-and-image-upgrade
branch
from
b48f791 to
f70110b
Compare
|
closing after discussion since we don't want to support the separate upgrade processes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The new skip flag of #2310 allows to separately disable k8s and image upgrades.
This PR cleans up the code to reflect this separation of responsibilities.
Proposed change(s)
UpgradeNodeVersionwithUpgradeK8sVersionandUpgradeImageVersionRelated issue
Additional info
K8s upgrade
https://github.com/edgelesssys/constellation/actions/runs/6158829291/job/16712399691
Checklist